Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NG1594 - CAP/Modal Propagate and Compact #8702

Merged
merged 6 commits into from May 16, 2024
Merged

Conversation

tjamesallen15
Copy link
Contributor

Explain the details for making this change. What existing problem does the pull request solve?

This pull request will add new settings propagateStyle and compactPanel.

Related github/jira issue (required):
Closes infor-design/enterprise-ng#1594

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • An e2e or functional test for the bug or feature.
  • A note to the change log.

@tjamesallen15 tjamesallen15 marked this pull request as ready for review May 9, 2024 07:06
@tjamesallen15 tjamesallen15 requested a review from a team as a code owner May 9, 2024 07:06
Copy link
Member

@tmcconechy tmcconechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjamesallen15
Copy link
Contributor Author

@tmcconechy under the request it says here, when using class compactPanel, it will add compact class that would have padding: 0
image

@tmcconechy
Copy link
Member

Oh, Ok. Maybe we can just take the contents out then for the sake of the example...

@tmcconechy
Copy link
Member

@tjamesallen15 you think it would work if we just made the CAP blank so it doesnt seem misformatted? I think it would still serve the same purpose

janahintal
janahintal previously approved these changes May 13, 2024
Copy link
Contributor

@janahintal janahintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link

@n-ace-ancog n-ace-ancog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected

image

@tmcconechy tmcconechy merged commit d1c37ef into main May 16, 2024
2 checks passed
@tmcconechy tmcconechy deleted the NG1594-cap-propagate-compact branch May 16, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal/Contextual Action Panel: consider adding new styling options
5 participants