7826 - Calendar Custom Colors

[tjamesallen15]

Explain the details for making this change. What existing problem does the pull request solve?

This pull request will fix custom colors render of events.

Related github/jira issue (required):
Closes #7826

Steps necessary to review your pull request (required):

• Pull this git repository, build, and run the app
• Go to http://localhost:4000/components/calendar/test-event-custom-colors.html
• See the custom event colors

Included in this Pull Request:

• An e2e or functional test for the bug or feature.
• A note to the change log.

[tmcconechy]

Looks good but can we make it accept the color names too.

i.e. ruby-10 -> ruby-100 and azure-10 -> azure-100 (for all color categories)

Otherwise looks good to me

[janahintal]

Event title in the Right Side event summary is not visible in some modes

• https://7826-calendar-custom-colors-enterprise.demo.design.infor.com/components/calendar/test-event-custom-colors.html?theme=new&mode=light&colors=default
• https://7826-calendar-custom-colors-enterprise.demo.design.infor.com/components/calendar/test-event-custom-colors.html?theme=new&mode=contrast&colors=default

Different event color displayed in Classic
e.g see Administrative Leave event color as the same as with Discretionary time off
https://www.loom.com/share/88671fa3af1243eca5431566a6c95169?sid=5fda1792-3d65-405f-96b3-e3579907023e

[glenlieorillo]

The color doesn't change when changing the event type.

Steps to reproduce:

1. Create new event by double clicking the desired date
2. Select type (eg. Discretionary Time Off)
3. Click Submit button
4. Click the created event
5. Change the event type then click again the Submit button
6. Change again the event type to Discretionary Time Off
7. Notice the event color

Screen.Recording.2024-05-03.at.3.44.39.PM.mov

[jbrcna]

title not visible in new theme and off in classic theme

Also,
event changes color when creating different events

[glenlieorillo]

Tab color for Sick Time is different.

When you change the view to Week/Day, the color is changed.

• Month View

• Week View

• Day View

Screen.Recording.2024-05-06.at.7.23.21.PM.mov

[tjamesallen15]

@janahintal

[janahintal]

Hi @tjamesallen15 I can still replicate the issue
https://www.loom.com/share/d6c7e610651f4b85b0c2a54c853a3e8b?sid=9f83321d-b4f9-4a57-b9e7-2bd538f52759

[tjamesallen15]

Done. please check again ty.

[tmcconechy]

@tjamesallen15 can you use lighter colors in this example https://7826-calendar-custom-colors-enterprise.demo.design.infor.com/components/calendar/test-event-custom-colors.html
Its just that it shows a color contrast issue on the page we shouldnt encourage.

Just change to colors in the first 3 rows https://main-enterprise.demo.design.infor.com/components/colors/example-index.html (10-30)

[n-ace-ancog]

Updating the event seems to revert to the default colors.

Screen.Recording.2024-05-21.at.6.58.14.PM.mov

[jbrcna]

opening an event and do nothing but submit changes the event color.
before

after

[tjamesallen15]

@tmcconechy @ericangeles see the qa findings above.

there are to types of json files here. one with custom-types, one with custom events.

calendar loads the with custom events (following its colors saved)
user click the custom event and press save
reverts back to the color saved from custom types not with the custom-events

my understanding is that it is a special events that's why it have a custom colors preloaded. should we save the colors of the custom colors?

[tmcconechy]

@tjamesallen15 I dont think that we should commit the custom colors and change the data. But if they override it on the API it should use the overrride (in all cases).

So might just be checking: if overridden use that ELSE use the data

[n-ace-ancog]

@tjamesallen15 @ericangeles @tmcconechy, the color persist after updating it without changing the event type. When changing the event type, the color still remains the same. Is this expected or the color should be tied on the event type?

Screen.Recording.2024-05-24.at.3.22.27.PM.mov

[jbrcna]

updating an event does not update its color.

also, the color of the header and title could be improved.