Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileUploadAdvanced: Ability to resize responsively #7892

Closed
paripireddymanikrishna opened this issue Sep 5, 2023 · 16 comments · Fixed by #8710
Closed

FileUploadAdvanced: Ability to resize responsively #7892

paripireddymanikrishna opened this issue Sep 5, 2023 · 16 comments · Fixed by #8710
Assignees
Labels
type: enhancement ✨ [3] Velocity rating (Fibonacci)

Comments

@paripireddymanikrishna
Copy link

paripireddymanikrishna commented Sep 5, 2023

Describe the bug
unable to resize the attachment component for both multi attachment and attachment component and dropdown component also

To Reproduce
image

image

Possible Specs (TJM)

  • by default has 300px width like an input field
  • in responsive forms will take the save of the responsive column
  • other fixed sizes?
  • may have issues with very small sized and text wrapping so may need a changing height as well
@tmcconechy tmcconechy added [3] Velocity rating (Fibonacci) status: clarification Issue needs clarification labels Sep 5, 2023
@tmcconechy
Copy link
Member

tmcconechy commented Sep 5, 2023

@paripireddymanikrishna do you mean you want it to be responsive to the same size of fields? or want to resize it as a user or something else? the issue is a bit unclear. Also i changed it to file upload which is the name of the component.

Also can you include sample markup used in the example you created?

@tmcconechy tmcconechy changed the title Resize the Attachment Component FileUploadAdvanced: Ability to resize responsively Sep 5, 2023
@tmcconechy tmcconechy removed the status: clarification Issue needs clarification label Sep 19, 2023
@tmcconechy
Copy link
Member

@paripireddymanikrishna tested this on https://main-enterprise.demo.design.infor.com/components/fileupload-advanced/example-index.html and it seems to be now the size of the page. Does that work for you?

@paripireddymanikrishna
Copy link
Author

@tmcconechy when we are using this component in widgets then size is different with another components like input field and it is taking more time to upload file

@tmcconechy
Copy link
Member

@paripireddymanikrishna not sure whats special about your case when it works on https://main-enterprise.demo.design.infor.com/components/fileupload-advanced/example-index.html

Can you try to do it the same way and see if it fixes it? Or provide a reduced test case / stackblitz (Template: https://stackblitz.com/edit/ids-quick-start-1651?file=src%2Fapp%2Fapp.component.ts)

As for it being slow. We dont have control over how you upload it but do note you probably want to use the send method like this example https://github.com/infor-design/enterprise/blob/main/app/views/components/fileupload-advanced/example-send.html our default sendFileToServer has a timer in it to slow it down for demo app. So maybe you didnt implement send properly

@paripireddymanikrishna
Copy link
Author

@tmcconechy I tried same as example given in IDS site and not added any custom CSS also. I tried in different versions as well but issue is same and I will send you credentials and details if you want

@tmcconechy
Copy link
Member

We usually insist on a reduced test case for looking at issues https://www.browserstack.com/guide/test-case-reduction-and-techniques

So could you make a small example that just shows the issue. You can either put the relevent code in a zip.
Or use our stackblitz templates:

NG: https://stackblitz.com/edit/ids-quick-start-1711?file=src%2Fapp%2Fapp.component.ts
Enterprise: https://stackblitz.com/edit/ids-enterprise-4991?file=index.js

Try perhaps to focus on what your passing in settings, any custom css or special placement or any special angular tags or something?

@paripireddymanikrishna
Copy link
Author

paripireddymanikrishna commented Jan 24, 2024

here is runnable example for above issue and still issue is reproducing here that is while uploading files using this component is taking more time.

https://stackblitz.com/edit/ids-quick-start-1711-qezkdj?file=src%2Fapp%2Fapp.component.html

@tmcconechy
Copy link
Member

@paripireddymanikrishna I cant find the code in this example but there is a thing about the component...

By default if you dont implement the send function it will slow the upload down and just do a fake upload for demonstration purposes. All you need to do is implement this function and do your own logic and it will bypass this logic.

https://github.com/infor-design/enterprise/blob/main/app/views/components/fileupload-advanced/example-send.html#L15

I dont get what you mean about the resize part of the issue but from what i see doing that should solve the issue

@tmcconechy
Copy link
Member

@paripireddymanikrishna does adding the method fix the slowness problem?
Can you elaborate on the steps to reproduce the resize issue please? Should this be closed?

@paripireddymanikrishna
Copy link
Author

Hi @tmcconechy , No it is still slow.
I am adding here example https://stackblitz.com/edit/ids-quick-start-1711-qezkdj?file=src%2Fapp%2Fapp.component.html

@paripireddymanikrishna
Copy link
Author

when we select any large size file it is taking time and in above just mentioned sample component and it same in widget as well

@tmcconechy
Copy link
Member

@paripireddymanikrishna where in that example did you implement the send function https://github.com/infor-design/enterprise/blob/main/app/views/components/fileupload-advanced/example-send.html#L15

Once you implement that you bypass the default "slow it down for visual" behavior and actually implement your logic to send it to the backend.

@paripireddymanikrishna
Copy link
Author

Hi @tmcconechy the soho-fileupload-advanced component itself taking more time while selecting file for reference I am attaching the video link

https://inforonline-my.sharepoint.com/:v:/g/personal/manikrishna_paripireddy_infor_com/EbPOIonQoCZOtev9UdEJzF8Brik0oqyiSiqv_pEFWtMU7A?e=WLgsSD

and this is stackblitz link ]
https://stackblitz.com/edit/ids-quick-start-1711-qezkdj?file=src%2Fapp%2Fapp.component.html

@tmcconechy
Copy link
Member

Will fix the responsive behaviour if we have time. But for the slow issue i think if you implement the send function it will work.
Also could try the new web component version. It doesnt have the send issue

@paripireddymanikrishna
Copy link
Author

@tmcconechy any idea in which fix version this available so that I will update in Jira ticket accordingly

@tmcconechy
Copy link
Member

@paripireddymanikrishna i can try and add this to release 4.96.0 which would be early June.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ [3] Velocity rating (Fibonacci)
Development

Successfully merging a pull request may close this issue.

3 participants