Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Bump github.com/grid-x/modbus from v0.0.0-20211113184042-7f2251c342c9 to v0.0.0-20240503115206-582f2ab60a18 #15276

Merged
merged 1 commit into from May 7, 2024
Merged

chore(deps): Bump github.com/grid-x/modbus from v0.0.0-20211113184042-7f2251c342c9 to v0.0.0-20240503115206-582f2ab60a18 #15276

merged 1 commit into from May 7, 2024

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented May 2, 2024 •
edited

Summary

This bumps the modbus dependency to handle strange devices as described in #11099.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #11099

@srebhan srebhan mentioned this pull request May 2, 2024
Closed
@srebhan srebhan changed the title chores(deps): Bump -github.com/grid-x/modbus from v0.0.0-20211113184042-7f2251c342c9 to v0.0.0-20240502103727-5255f1c26944 chore(deps): Bump -github.com/grid-x/modbus from v0.0.0-20211113184042-7f2251c342c9 to v0.0.0-20240502103727-5255f1c26944 May 2, 2024
@telegraf-tiger telegraf-tiger bot added the chore label May 2, 2024
@srebhan srebhan added the dependencies Pull requests that update a dependency file label May 2, 2024
@srebhan srebhan changed the title chore(deps): Bump -github.com/grid-x/modbus from v0.0.0-20211113184042-7f2251c342c9 to v0.0.0-20240502103727-5255f1c26944 chore(deps): Bump github.com/grid-x/modbus from v0.0.0-20211113184042-7f2251c342c9 to v0.0.0-20240502103727-5255f1c26944 May 2, 2024
@srebhan srebhan self-assigned this May 2, 2024
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 2, 2024
@srebhan srebhan assigned powersj and DStrand1 and unassigned srebhan May 2, 2024
@srebhan srebhan removed the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 3, 2024
@srebhan srebhan changed the title chore(deps): Bump github.com/grid-x/modbus from v0.0.0-20211113184042-7f2251c342c9 to v0.0.0-20240502103727-5255f1c26944 chore(deps): Bump github.com/grid-x/modbus from v0.0.0-20211113184042-7f2251c342c9 to v0.0.0-20240503115206-582f2ab60a18 May 3, 2024
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 3, 2024
powersj
powersj approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for driving this and providing fixes upstream!

@powersj powersj removed their assignment May 3, 2024
@srebhan
chore(deps): Bump github.com/grid-x/modbus from v0.0.0-20211113184042…
2d26ecd 
…-7f2251c342c9 to v0.0.0-20240503115206-582f2ab60a18
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented May 6, 2024

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@DStrand1 DStrand1 merged commit 0966bcb into influxdata:master May 7, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.30.3 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@DStrand1 DStrand1 DStrand1 approved these changes

Assignees

@DStrand1 DStrand1

Labels
chore dependencies Pull requests that update a dependency file ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.30.3
Development

Successfully merging this pull request may close these issues.

[inputs.modbus] Error in plugin: modbus: response data size '5' does not match count '4'
3 participants
@srebhan @powersj @DStrand1