-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from npm to pnpm #1875
Open
jamesst20
wants to merge
9
commits into
inertiajs:master
Choose a base branch
from
jamesst20:pnpm_setup
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Migrate from npm to pnpm #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesst20
force-pushed
the
pnpm_setup
branch
2 times, most recently
from
May 12, 2024 18:56
b79bbe4
to
abd39cf
Compare
jamesst20
added a commit
to jamesst20/inertia
that referenced
this pull request
May 12, 2024
[inertiajs#1875] Migrate from npm to pnpm
jamesst20
added a commit
to jamesst20/inertia
that referenced
this pull request
May 12, 2024
[inertiajs#1875] Migrate from npm to pnpm
jamesst20
added a commit
to jamesst20/inertia
that referenced
this pull request
May 12, 2024
[inertiajs#1875] Migrate from npm to pnpm
jamesst20
force-pushed
the
pnpm_setup
branch
2 times, most recently
from
May 12, 2024 19:46
d8ddb88
to
692a4ca
Compare
jamesst20
added a commit
to jamesst20/inertia
that referenced
this pull request
May 12, 2024
Merge punyflash/inertia with some tweaks and fixes
jamesst20
added a commit
to jamesst20/inertia
that referenced
this pull request
May 12, 2024
Merge punyflash/inertia with some tweaks and fixes
jamesst20
added a commit
to jamesst20/inertia
that referenced
this pull request
May 12, 2024
Merge punyflash/inertia with some tweaks and fixes
jamesst20
added a commit
to jamesst20/inertia
that referenced
this pull request
May 12, 2024
[inertiajs#1875] Migrate from npm to pnpm
jamesst20
added a commit
to jamesst20/inertia
that referenced
this pull request
May 12, 2024
[inertiajs#1875] Migrate from npm to pnpm
jamesst20
added a commit
to jamesst20/inertia
that referenced
this pull request
May 16, 2024
[inertiajs#1875] Migrate from npm to pnpm
jamesst20
added a commit
to jamesst20/inertia
that referenced
this pull request
May 28, 2024
[inertiajs#1875] Migrate from npm to pnpm
jamesst20
added a commit
to jamesst20/inertia
that referenced
this pull request
May 28, 2024
[inertiajs#1875] Migrate from npm to pnpm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is based from this branch #1874
This is just one small commit: 7dd0a03
Replace npm by pnpm.
Pnpm is a much better package manager. If you are curious about its differences, I recommend you to google it.
Syntax and usage is pretty much identical
The reason why it's a good idea is because pnpm properly scopes packages unlike npm. As you can see in the single commit of this branch, I had to add missing packages to few repos. This should have never worked in the first place. This prevent weird bugs as well where the wrong package version is used for building as well.
Also, using @inertiajs/core from the workspace would be a better approach because sometimes both adapter and core need an update. i.e adding a new type that would be missing from the core in the currently published version.
Pnpm automatically re-alias properly packages referenced from the workspace.
https://pnpm.io/workspaces