Pass the full page object to resolve component #1864
+15
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May I pull your attention here? :) @reinink I believe it's a really quick QA without any kind of side effect and I did it for all adapters and typescript types |
|
Yup, I think this makes sense! Will test this out and let you know. |
If you merge Svelte Typescript support, I will update this PR very quickly to include new Svelte types. I can tell this works well for Svelte, been using this branch for 2 weeks about everyday |
jamesst20
added a commit
to jamesst20/inertia
that referenced
this pull request
May 12, 2024
[inertiajs#1864] Pass the full page object to resolveComponent
jamesst20
added a commit
to jamesst20/inertia
that referenced
this pull request
May 12, 2024
jamesst20
added a commit
to jamesst20/inertia
that referenced
this pull request
May 12, 2024
jamesst20
added a commit
to jamesst20/inertia
that referenced
this pull request
May 12, 2024
jamesst20
added a commit
to jamesst20/inertia
that referenced
this pull request
May 12, 2024
jamesst20
added a commit
to jamesst20/inertia
that referenced
this pull request
May 12, 2024
[inertiajs#1864] Pass the full page object to resolveComponent
jamesst20
added a commit
to jamesst20/inertia
that referenced
this pull request
May 16, 2024
[inertiajs#1864] Pass the full page object to resolveComponent
jamesst20
added a commit
to jamesst20/inertia
that referenced
this pull request
May 28, 2024
[inertiajs#1864] Pass the full page object to resolveComponent
jamesst20
added a commit
to jamesst20/inertia
that referenced
this pull request
May 28, 2024
[inertiajs#1864] Pass the full page object to resolveComponent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion #1863