fix scroll-region on html element with overflow-scroll #1782
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. use this.page instead of page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
restoreScrollPositions()insetPage()method if we have scroll-region. Usethis.pageinstead ofpage.This is related to #1211
In line 454 :
console.log(page.scrollRegions)is always undefined, and I don't know why.If we do only
console.log(page), we can see the scrollRegions field inside browser inspector, but I think it was populated asynchronously ?With this version,
scroll-regionwork well, and scrolling items are not reset when we submit the form (for example), butthis.pageis kind of a cheat ?