Log SSR errors in Laravel #425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow PHP 8.2 * Update workflow for PHP 8.2 * Formatting * Set minimum PHP 8.2 versions Co-authored-by: Jonathan Reinink <jonathan@reinink.ca> (cherry picked from commit b00fe8c)
|
Heya. We removed our master branch. Feel free to re-attempt this to 1.x! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the only place SSR errors are logged is in the output of the Node process which is not particularly useful for production systems. Several times we have managed to make code changes live and accidentally break the SSR without knowing.
This change will accompany another PR on intertia so that SSR errors are included in the Node server response and logged in Laravel via whichever adapters have been setup in Laravel.
The isset is required to make the change backwards compatible with the node server when it doesn't respond with a body.
This is an example of an SSR error logged using the https://github.com/TheoKouzelis/laravel-airbrake adapter
