feat: trigger event before sending response #294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dillingham
reviewed
Oct 12, 2021
src/Response.php
Outdated
| @@ -100,6 +101,10 @@ public function toResponse($request) | |||
| 'version' => $this->version, | |||
| ]; | |||
|
|
|||
| if (env('APP_DEBUG', false)) { | |||
There was a problem hiding this comment.
config('app.debug')dont use env outside of config files
|
I would be happy about it too |
|
Heya. We removed our master branch. Feel free to re-attempt this to 1.x! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will trigger an event before the actual Inertia response it sent. The name of the event is up to discussion and maybe you have a better idea. Having this event it will be easy to implement a widget for the Debugbar to inspect the props.