Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-admin CRUD views for ParticipationTag and ParticipationRole #745

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Non-admin CRUD views for ParticipationTag and ParticipationRole #745

wants to merge 5 commits into from

Conversation

dzhuang
Copy link
Contributor

@dzhuang dzhuang commented Oct 22, 2020 •
edited

Fixing #299 and #303

  • Tests.

@dzhuang dzhuang changed the title Non-admin CRUD views for ParticipationTag and ParticipationRole [WIP] Non-admin CRUD views for ParticipationTag and ParticipationRole Oct 22, 2020
@inducer
Copy link
Owner

inducer commented Oct 22, 2020

FYI Github has a "draft" mode for PRs to express "WIP" status (under "Reviewers" in the sidebar).

@inducer
Copy link
Owner

inducer commented Oct 22, 2020

That's also where you can request a review once you think it's ready for a look.

@dzhuang
Copy link
Contributor Author

dzhuang commented Oct 23, 2020

Thanks for the information.

FYI Github has a "draft" mode for PRs to express "WIP" status (under "Reviewers" in the sidebar).

@dzhuang dzhuang marked this pull request as draft October 23, 2020 00:11
@dzhuang dzhuang changed the title [WIP] Non-admin CRUD views for ParticipationTag and ParticipationRole Non-admin CRUD views for ParticipationTag and ParticipationRole Oct 24, 2020
@dzhuang dzhuang marked this pull request as ready for review October 24, 2020 11:00
@dzhuang dzhuang requested a review from inducer October 24, 2020 12:30
inducer
inducer reviewed Oct 26, 2020
View reviewed changes
Copy link
Owner

@inducer inducer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this. Some comments below.

course/templates/course/participation-role-table.html Outdated Show resolved Hide resolved
course/templates/course/participation-role-table.html Outdated Show resolved Hide resolved
course/templates/course/participation-role-table.html Outdated Show resolved Hide resolved
course/templates/course/participation-tag-table.html Outdated Show resolved Hide resolved
course/templates/course/participation-role-table.html Outdated Show resolved Hide resolved
course/templates/course/participation-role-table.html Outdated Show resolved Hide resolved
course/templates/course/participation-role-table.html Show resolved Hide resolved
course/templates/course/participation-role-list.html Outdated Show resolved Hide resolved
course/templates/course/gradebook-participant-list.html Outdated Show resolved Hide resolved
course/templates/course/course-base.html Outdated Show resolved Hide resolved
@dzhuang dzhuang force-pushed the ptag_crud branch 2 times, most recently from 03fee06 to c48e0f1 Compare October 28, 2020 04:33
@dzhuang dzhuang requested a review from inducer October 29, 2020 01:07
@dzhuang dzhuang mentioned this pull request Oct 29, 2020
Open
Base automatically changed from master to main March 8, 2021 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inducer inducer Awaiting requested review from inducer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dzhuang @inducer