Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count points from optional pages #623

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

inducer
Copy link
Owner

@inducer inducer commented Oct 2, 2018

Closes #621

@dzhuang Could you review/comment?

@codecov
Copy link

codecov bot commented Oct 2, 2018

Codecov Report

Merging #623 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #623      +/-   ##
==========================================
+ Coverage   96.93%   96.94%   +<.01%     
==========================================
  Files          45       45              
  Lines       11076    11079       +3     
  Branches     2060     2061       +1     
==========================================
+ Hits        10737    10740       +3     
  Misses        292      292              
  Partials       47       47
Impacted Files Coverage Δ
course/flow.py 99.19% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acb7e32...5a44faf. Read the comment docs.

@inducer
Copy link
Owner Author

inducer commented Oct 23, 2018

@dzhuang ping :)

@dzhuang
Copy link
Contributor

dzhuang commented Oct 30, 2018

See discussion in #621. I think what you want is a bonus page?

@inducer
Copy link
Owner Author

inducer commented Oct 31, 2018

I think what you want is a bonus page?

Yeah, pretty much. Do we have a dfiferent mechanism for those? Because optional + has value makes a lot of sense to me to express that.

@dzhuang
Copy link
Contributor

dzhuang commented Oct 31, 2018

I agree. So there are some agreements need to be reached to achieve that:

  1. Warning that there're bonus page unanswered (for pages that have non-zero values), when a user is finishing a flow with bonus pages.
  2. Display bonus points in those pages
  3. Any more?

@inducer
Copy link
Owner Author

inducer commented Oct 31, 2018

Warning that there're bonus page unanswered (for pages that have non-zero values), when a user is finishing a flow with bonus pages.

Only if they carry points.

Display bonus points in those pages

Could simply be shown as "5 points (optional)".

We may want a separate grade sum for "bonus points" on the results page--maybe.

@dzhuang
Copy link
Contributor

dzhuang commented Nov 1, 2018

That sounds reasonable, but I have no time to do that in a while. Maybe I can help in testing if you can submit a patch.

@inducer
Copy link
Owner Author

inducer commented Nov 1, 2018

The earliest time where I envision I'll have some time to hack Relate is around Christmas. I'm teaching a big, Relate-heavy course in the spring, so I have some motivation.

@dzhuang
Copy link
Contributor

dzhuang commented Nov 2, 2018

So I'll wait for your ping :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants