Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable source build cache on pocl/nvidia #749

Merged
merged 4 commits into from
May 28, 2024

Conversation

matthiasdiener
Copy link
Contributor

@matthiasdiener matthiasdiener commented May 7, 2024

Followup of #738.

Please squash

@matthiasdiener matthiasdiener changed the title Disabled source build cache on pocl/nvidia Disable source build cache on pocl/nvidia May 9, 2024
@matthiasdiener matthiasdiener force-pushed the disable-build-cache-v2 branch 3 times, most recently from a226c17 to 1a9ad0d Compare May 9, 2024 23:06
@matthiasdiener
Copy link
Contributor Author

matthiasdiener commented May 9, 2024

1a9ad0d outlines a way to ensure pocl uses PID-local caches. This is ready for a first look @inducer @majosm

@matthiasdiener matthiasdiener marked this pull request as ready for review May 10, 2024 14:29
pyopencl/__init__.py Outdated Show resolved Hide resolved
@matthiasdiener matthiasdiener force-pushed the disable-build-cache-v2 branch 2 times, most recently from 89669e1 to acb66cc Compare May 24, 2024 17:38
@matthiasdiener
Copy link
Contributor Author

matthiasdiener commented May 24, 2024

This is ready for review @inducer. I have not noticed any cache concurrency issues with this PR+the new pocl version (5.0 * _5).

@inducer inducer merged commit 4ff632c into inducer:main May 28, 2024
17 checks passed
@matthiasdiener matthiasdiener deleted the disable-build-cache-v2 branch May 28, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants