Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Tree implementation #694

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

add Tree implementation #694

wants to merge 9 commits into from

Conversation

matthiasdiener
Copy link
Collaborator

based on #350 / #690

@matthiasdiener matthiasdiener self-assigned this Oct 18, 2022
@inducer
Copy link
Owner

inducer commented Oct 18, 2022

The authorship information on the commits is incorrect. For the tree, this should show Kaushik as the author, and you as the committer. For the tests, that should show you as the author, i.e. you need a minimum of two commits.

@matthiasdiener
Copy link
Collaborator Author

The authorship information on the commits is incorrect. For the tree, this should show Kaushik as the author, and you as the committer. For the tests, that should show you as the author, i.e. you need a minimum of two commits.

I think this should be fixed now.

@matthiasdiener
Copy link
Collaborator Author

This is ready for review

inducer
inducer reviewed Dec 27, 2022
View reviewed changes
loopy/schedule/tree.py
@@ -0,0 +1,269 @@
__copyright__ = "Copyright (C) 2022 Kaushik Kulkarni"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard for me to see here how this was changed vs. the original.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've split up the commits into Kaushik's original implementation (7f50179), followed by my changes on top of that initial commit. Does that make the changes clearer?

@matthiasdiener matthiasdiener mentioned this pull request Jan 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikcfd kaushikcfd Awaiting requested review from kaushikcfd

@inducer inducer Awaiting requested review from inducer

Assignees

@matthiasdiener matthiasdiener

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiasdiener @inducer @kaushikcfd