Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receipt files export #6338

Merged
merged 14 commits into from
Jun 4, 2024
Merged

Conversation

micsucmed
Copy link
Contributor

closes #6331

@micsucmed micsucmed force-pushed the receipt-files-export branch 2 times, most recently from bf9c9af to 14224e1 Compare May 15, 2024 14:19
@ThiefMaster ThiefMaster added this to the v3.3 milestone May 15, 2024
@micsucmed micsucmed marked this pull request as draft May 15, 2024 15:04
@ThiefMaster
Copy link
Member

For the failing tests:

  • I suggest skipping the url since including token URLs (which has an expiry) in the export doesn't make lots of sense
  • The file paths also have a reference to the IDs, so currently there's another failure in the tests when you just run some tests, e.g. using pytest indico/modules/users/export_schemas_test.py because then less IDs have been consumed (we do not commit anything during/between tests, but auto-incrementing serial IDs are consumed regardless).

I just pushed commits fixing both these issues.

@micsucmed micsucmed marked this pull request as ready for review May 23, 2024 15:02
indico/modules/users/export_schemas.py Outdated Show resolved Hide resolved
indico/modules/users/export.py Outdated Show resolved Hide resolved
@ThiefMaster ThiefMaster enabled auto-merge (squash) June 4, 2024 15:20
@ThiefMaster ThiefMaster merged commit ee55c87 into indico:master Jun 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Receipt files missing from data export
3 participants