Display pictures from PictureField in some email notifications #6336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
May 14, 2024
ThiefMaster
force-pushed
the
email-picture-display
branch
from
3db8026
to
7cebdbe
Compare
ThiefMaster
reviewed
May 22, 2024
indico/modules/events/registration/templates/emails/base_registration_details.html
Outdated
Show resolved
Hide resolved
|
@SegiNyn I fixed a few problems I found and made some improvements. Please have a look before I merge it. |
|
Hi @ThiefMaster, it looks good, I just noticed that the yellow highlight on new texts were not displaying so I fixed that |
ThiefMaster
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The picture is displayed in the registration creation and modification email notifications since those are the places that show field data.