Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow documents to be generated from within the registration details #6306

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Allow documents to be generated from within the registration details #6306

wants to merge 11 commits into from
+41 −7

Conversation

hitenvidhani
Copy link

@hitenvidhani hitenvidhani commented Apr 19, 2024 •
edited by ThiefMaster

No description provided.

@hitenvidhani hitenvidhani marked this pull request as ready for review April 19, 2024 12:37
@ThiefMaster ThiefMaster linked an issue Apr 19, 2024 that may be closed by this pull request
Documents: allow documents to be generated from within the registration details #6212
Open
@hitenvidhani
Copy link
Author

hitenvidhani commented Apr 19, 2024 •
edited

@ThiefMaster Should I update CHANGES.rst as a part of this PR?

@ThiefMaster
Copy link
Member

I think the placement of the button is nice, but it looks really bad when there are no documents yet in a registration:

image

I suggest keeping the box title and showing a nice "There are no documents yet" message inside it.

@hitenvidhani
Copy link
Author

Fixed it @ThiefMaster

@ThiefMaster
Copy link
Member

image

image

  • The title should stay the same
  • There shouldn't be two titles in case of existing documents
  • The message I proposed should be in the "body" are of the box, not the title area...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThiefMaster ThiefMaster Awaiting requested review from ThiefMaster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documents: allow documents to be generated from within the registration details
2 participants
@hitenvidhani @ThiefMaster