Improve HiddenUnless for composite field #6267
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could you split that into a separate commit please? That way it's easier for us to just remove that commit when we are ready to merge it. |
ThiefMaster
reviewed
Apr 3, 2024
indico/web/forms/validators.py
Outdated
Comment on lines
78
to
82
| i = 0 | ||
| while i < len(v): | ||
| if values[i] is not None and v[i] not in values[i]: | ||
| return False | ||
| i += 1 |
There was a problem hiding this comment.
That looks like a good case for something like any(... for ... in zip(v, values))
There was a problem hiding this comment.
Don't see how I can use the zip...
best can do:
if(any(v[i] for i in range(len(v)) if values[i] and v[i] not in values[i]):
return False
Done: #6268 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request change for HiddenUnless validator:
this change renders the validator working on field composed of list of other fields (like "visibility" in Participant List Privacy form),
it also adds an option "inverted" for the validator.
Note:
I added 2 test fields on RegistrationPrivacyForm for visual testing.