Improve event details markup structure #6116
Conversation
foxbunny
commented
Dec 25, 2023
foxbunny
commented
- Add appropriate section headings to event details
- Replace the jQuery code for the participant list with a custom element
- Fix minor layout issues and remove .align-top class
foxbunny
force-pushed
the
event-page-structure
branch
from
a4dbf4b
to
f01bef0
Compare
ThiefMaster
force-pushed
the
a11y
branch
2 times, most recently
from
2ed86db
to
7e0dbcc
Compare
foxbunny
force-pushed
the
event-page-structure
branch
2 times, most recently
from
ebf7b31
to
4d0f625
Compare
|
@ThiefMaster Is this a pipeline issue? Maybe you could re-run this? |
|
The |
ThiefMaster
changed the title
foxbunny
force-pushed
the
event-page-structure
branch
2 times, most recently
from
84e0295
to
00dd0af
Compare
| } | ||
| linesFound++; | ||
| if (linesFound > cutOffLines) { | ||
| // We have crossed the cutOffLines thrshold, so no need to test further |
There was a problem hiding this comment.
| // We have crossed the cutOffLines thrshold, so no need to test further | |
| // We have crossed the cutOffLines threshold, so no need to test further |
|
Is there anything missing in the PR? |
Other than that typo you pointed out, I don't think so. |
|
The zoom join button looks rather broken now: The event description (especially if single-line) and external references are no longer properly aligned: |
indico/modules/events/registration/templates/display/event_header.html
Outdated
Show resolved
Hide resolved
|
The 100px margin of the definition list in old: new: |
|
|
||
| markCollapsible = () => { | ||
| clearTimeout(this.debounceTimer); | ||
| this.debounceTimer = setTimeout(() => { |
There was a problem hiding this comment.
you don't want to use _.debounce() from lodash? ;)
|
How do you get that even thing? |
|
the zoom thing? unfortunately only by having the zoom plugin enabled and configured... but the
|
Can you give me the outer HTML for the common ancestor of the button and the chevron? I'll insert it into the page and figure out what's going on. |
Those should be converted to a table with |
|
here's the html for the full videoconference thing: https://bpa.st/raw/HL2NWPWW5NVGGPMOTYLTFCSEFE |
|
Interesting... so the expand/collapse trigger comes after the details. That must be fixed, too. I'll get on this tomorrow. |
|
I would be fine converting this to a table BTW :) I think back then I thought a dl has better semantics than a table, since it's not really tabular data... BTW the source for this in the plugins is |
It's technically not tabular data. That's why Tbh, I don't really know what the best markup would be in these cases. As far as screen readers and such are concerned, it's enough that these are read sequentially. A colon is usually desirable to add a pause between the label and the value, tho. |
|
Ok, so, since the plugin is not part of the code base, I'm going to revisit it at a later date. For now I've assumed that 100px was enough margin, and converted it to 8em. Let me know if that works. I'll install the plugin later once I'm done on the existing PRs and revisit the table layout later. |
foxbunny
force-pushed
the
event-page-structure
branch
2 times, most recently
from
709028f
to
f55a01a
Compare
foxbunny
force-pushed
the
event-page-structure
branch
from
f55a01a
to
07a3de1
Compare
- Add appropriate section headings to event details - Replace the jQuery code for the participant list with a <ind-collapsible> custom element - Fix minor layout issues and remove .align-top class
foxbunny
force-pushed
the
event-page-structure
branch
from
07a3de1
to
9942f69
Compare
