support important advice #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
madvisesystem call is actually kind of important in more scenarios that you've covered, and the POSIX values are the same in OSX and linux (I checked .h files in both). The sequential advice, in particular, can have a dramatic effect on the overall VM system (without it you can accidentally kick a lot of stuff out of RAM that is important, unnecessarily).I added a big docstring to the new method to explain.
The instructions for building didn't work for me...perhaps missing a call to gen the .h file? So, I wasn't able to build it to test, but the change is very small.