COMMON-5148 Added support for AARCH64 in Linux #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkw
reviewed
May 1, 2023
mkw
reviewed
May 1, 2023
mmorrisontx
reviewed
May 1, 2023
|
@mkw @mmorrisontx any additional work needed on this one? |
mkw
approved these changes
May 10, 2023
|
Can we go ahead and merge this? I'm not authorized to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opted to go for an approach that will allow anyone to compile for both architectures. To this end I used the aarch64-linux-gnu-gcc/x86_64-linux-gnu-gcc compilers that need to be installed to build for the other platforms. To ensure that we don't enter infinite loops I added a REALARCH variable that will make sure we don't build cross-cross-platform. The binaries were rebuilt using GLIBC 2.31. I have tested compiling, building, and running on both AARCH64 and X86_64 Linux systems as well as verifying there were no regressions in the OS X build/compiles.