New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROC-1475: Suppress 100% allocations #164
Open
zacharygoodwin
wants to merge
10
commits into
indeedeng:master
Choose a base branch
from
zacharygoodwin:PROC-1475
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b85f3c5
PROC-1475: Suppress 100% allocations
zacharygoodwin 091a144
PROC-1475: Refactor duplicated logic into single method
zacharygoodwin baa6a44
PROC-1475: Rename and add unit test
zacharygoodwin df1556a
PROC-1475: Rename method for clarity
zacharygoodwin 64f7404
PROC-1475: Rename method for clarity
zacharygoodwin bbe788c
PROC-1475: Do not filter out 100% allocations for showGroups endpoint
zacharygoodwin cf0dafa
PROC-1475: Rename to loggableAllocation
zacharygoodwin ba17e42
PROC-1475: Add public method for rolled out allocations logging string
zacharygoodwin 4933db6
PROC-1475: Rename method
zacharygoodwin 547a9f9
PROC-1475: Update documentation of toVerifyGroupsString()
zacharygoodwin File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible allocation.getRanges() return null?