New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROC-1334: Add library support for rule filtering #142
base: master
Are you sure you want to change the base?
Conversation
812f7dc
to
ef0d7e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We might need to merge this MR #140 firstly to fix the build
import java.util.Set; | ||
import java.util.Stack; | ||
|
||
class NodeHunter implements NodeVisitor { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add some javadoc in this class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay added some explanation.
@@ -80,4 +80,44 @@ public static boolean versionInRange( | |||
} | |||
return inRange(version, start, end); | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given all those code will only be used outside the proctor library. https://indeed-pte.slack.com/archives/C1F00STA9/p1688590802320449?thread_ts=1688582115.448299&cid=C1F00STA9
Can we add java doc to each of those methods to explain it is not meant to be called inside proctor lib?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, can we create a subclass and only the subclass has those extra methods?
See https://bugs.indeed.com/browse/PROC-1334 for context.