More readme updates. #300
Draft
More readme updates. #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bostwickenator
commented
Jul 6, 2023
README.md
Outdated
| @@ -278,7 +274,7 @@ iWF allows you to start a workflow with a fixed cron schedule like below | |||
| // or timed out, the workflow will be retried based on the retry policy. While the workflow is retrying, it won't | |||
| // schedule its next run. If the next schedule is due while the workflow is running (or retrying), then it will skip | |||
| that | |||
| // schedule. Cron workflow will not stop until it is terminated or cancelled (by returning cadence.CanceledError). | |||
| // schedule. Cron workflow will not stop until it is terminated or canceled (by returning cadence.CanceledError). | |||
There was a problem hiding this comment.
cadence.CanceledError seems incorrect here given the two backends.
There was a problem hiding this comment.
Ahh right. I think we can just remove this part. Returning cancel error is not supported in IWF. The only way to cancel a workflow is call the stop workflow api ( the stopType is cancel by default)
|
I'll resolve the conflicts shortly. |
Btw there is only one conflict. There is a resolve conflict button in this PR and you can use it to resolve it easily |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More updates to the readme file. Work in process.