v2.12.0 (issue210-address-as-parameter) - Adding ADDRESS as a potential parameter #272
Conversation
|
I just noticed you have another PR that is going to convert this library into TypeScript (v3.0.0). If you want to do that first then we can go in and make similar changes we can do that too. |
|
Hi @trevorrd - apologies for the delay! The Typescript migration has now been completed, so if you're willing to update this, I'm happy to get this merged. Apologies for the duplicated work! |
…to this fork. Exported a MapException class, and made more changes to the maps to include passing an address as a query string to those individual maps. Still have a number to update until it's fully done.
…ll address to each of the map apps. A few either did NOT support passing the destination address or it wasn't documented. Ready to open a PR.
…eed to double check the compare files then a PR may be ready.
Hey Thomas (@tschoffelen), Thanks! |
|
It's taken me way too long (apologies again), but it's merged! Thanks again @trevorrd for the amazing work on this, quite a big new feature you've shipped here! |
|
🎉 This PR is included in version 3.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR is to address issue210-address-as-parameter. I've made the changes to now allow developers to use an address instead of latitude and longitude coordinates. This is what I had commented on earlier and you, Thomas Schoffelen, had commented and said,
It's not a use case I personally have, because I want to send users to a specific location rather than doing a search, but I can understand why that would be useful. I'm still happy to accept a PR for that functionality if you'd like to add it!So here is my pull request. Please review it, give me any feedback, if you see anything I need to update or change please let me know.