Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visible layers only flag default set to false #5125

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

vermeulendivan
Copy link

Fix #5121

Reasoning for this change:

  • A user (especially a user new to QGIS or InaSAFE) will not always know that their layer (which has a keyword assigned) not showing as an option for an event, “how many” or aggregate area is caused by the layer being disabled in the QGIS layers list;
  • If a user wants to disable the layer in the layers list to look at underlying layers (e.g. disable a layer which contains 100000s of buildings to look at a hazard layer), the layer will be removed from the selected event, “how many” and aggregate selection – this will not happen if this option is disabled;
  • This might even result in another layer being selected (which is still active in the QGIS layers list), unknowingly to the user;
  • Some data also loads extremely long, so a user might want to disable such a layer in the QGIS layers list for performance reasons, but with this option enabled they are forced to leave the layer active; and
  • The option in the settings has NOT been removed. Its only the default which is changed to disable it to make it more user friendly for someone new to QGIS or InaSAFE. A user can still change this setting if they prefer it as such.

image

Checklist:

  • Commit messages are descriptive and explain the rationale for changes
  • Add to the changelog in metadata.txt if it's a new feature
  • Unit test for new code added
  • Request someone to review or test your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layer assigned as keyword will not be available if the layer is disabled
1 participant