boilerplate for inasafe report processing algorithm #5070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gustry
reviewed
Oct 25, 2019
| @@ -0,0 +1,2 @@ | |||
| # coding=utf-8 | |||
There was a problem hiding this comment.
We are now in Python 3, not needed anymore
| import tempfile | ||
|
|
||
| from PyQt5.QtCore import QCoreApplication, QDate, QSettings | ||
| from PyQt5.QtWidgets import QDateEdit |
There was a problem hiding this comment.
I think in InaSAFE, we were using from qgis.PyQt ..., isn't it?
|
|
||
| def tr(self, string): | ||
| """Translate string on processing context.""" | ||
| return QCoreApplication.translate('Processing', string) |
There was a problem hiding this comment.
This would create another context in Transifex, why not using the normal tr already in InaSAFE?
| string should be a unique, short, character only string, eg "qgis" or | ||
| "gdal". This string should not be localised. | ||
| """ | ||
| return 'geosys' |
| within the GUI. | ||
| This string should be short (e.g. "Lastools") and localised. | ||
| """ | ||
| return 'GEOSYS' |
|
Thanks @myarjunar @Gustry I will take over the PR |
|
@myarjunar I was so excited to see a PR with Processing ;-) And then i noticed it was only a template. Good work @lucernae. Processing is a framework, so it's not easy sometimes to fit in this framework. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fba-report.zip