allow a selection on the exposure layer too #4786
Open
+114
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have an issue with raster layer (not checking for selected features). |
|
hi @Gustry - I have little time for technical work now ;( |
|
No worries, I think I will target it for 5.0. I still need to polish this feature.
|
Gustry
force-pushed
the
selected_exposure
branch
from
daedf0c
to
0b52df9
Compare
|
Raster exposure fixed |
Gustry
force-pushed
the
selected_exposure
branch
from
0b52df9
to
c1f17f5
Compare
Gustry
force-pushed
the
selected_exposure
branch
from
c1f17f5
to
8c7d305
Compare
|
@ismailsunni I updated this branch with develop to fix conflicts. But I have no idea what is wrong with Travis. I can't see any error. The make docker-test is fine on my local. Any idea? |
|
yeah, this is strange... I restarted Travis, let's see what happen. |
|
I already restarted many times ... |
Gustry
force-pushed
the
selected_exposure
branch
3 times, most recently
from
09d5cc2
to
595ebf6
Compare
|
I will continue the PR, updating with develop |
ismailsunni
force-pushed
the
selected_exposure
branch
from
595ebf6
to
6d959a7
Compare
|
This PR is leading to a crash of Travis. Something with signals from the map canvas. I was having trouble |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it fix?
I did that quickly. Maybe if we want it for 4.3, it needs some testing to check I didn't break anything or it's working correctly
it's a little bit more than one line like @timlinux said this morning ;-)
Checklist: