Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct effect after changing needs profile #3976

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

myarjunar
Copy link
Collaborator

What does it fix ?

@myarjunar myarjunar changed the title Dirext effect after changing needs profile Direct effect after changing needs profile Mar 1, 2017
@@ -1766,6 +1765,7 @@ def post_process(self, layer):
# Set the layer title
layer_title(layer)

from safe.definitions.post_processors import post_processors
Copy link
Contributor

@Gustry Gustry Mar 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we can't import post_processors at the beginning of file as usual ? If yes, you should put a comment why you want to import not at the beginning. Same comment where you import not at the beginning. It would be if we can call reload_minimum_needs_definition, no ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we can't import post_processors at the beginning of file as usual ?

I think yes if we want to have a direct effect after changing needs profile, post_processors value has to be changed to apply new minimum needs post processors. I'll write a comment for it.

@myarjunar
Copy link
Collaborator Author

layer properties - number of people fields_032
layer properties - analysis_impacted fields_031

Need your help, I'm getting stuck here 😅 @Gustry . If you look at those pictures, after changing needs profile then run the IF, on analysis_impacted layer I didn't get the same minimum needs as aggregation_impacted layer. What probably caused this?

@lucernae
Copy link
Collaborator

lucernae commented Mar 2, 2017

I'm taking this with @myarjunar .

@Gustry
Copy link
Contributor

Gustry commented Mar 2, 2017

ok great, I was going to check. I will let you

@ismailsunni
Copy link
Member

1 month later.
How is it going @lucernae @myarjunar ?

@Gustry
Copy link
Contributor

Gustry commented Apr 3, 2017

Still in progress, we have an issue with these missing fields. I will try to fetch this code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants