Update enum for when_made for createListing #13
Conversation
| @@ -76,7 +76,7 @@ public function testValidData() | |||
| "tags" => array('fashion, othertag'), | |||
| "who_made" => "collective", | |||
| "is_supply" => true, | |||
| "when_made" => "2010_2015", | |||
| "when_made" => "2010_2016", | |||
There was a problem hiding this comment.
In order to not have to change this every year, let's change this value to 2000_2009. What do you think?
There was a problem hiding this comment.
Sounds Good
On Thu, Sep 1, 2016 at 12:39 PM Iñaki Abete notifications@github.com
wrote:
In tests/Etsy/EtsyApiBuildRequestTest.php
#13 (comment):@@ -76,7 +76,7 @@ public function testValidData()
"tags" => array('fashion, othertag'),
"who_made" => "collective",
"is_supply" => true,
"when_made" => "2010_2015","when_made" => "2010_2016",In order to not have to change this every year, let's change this value to
2000_2009. What do you think?—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/inakiabt/etsy-php/pull/13/files/b7189dc554310d15f481bb072ef40019dbca9383#r77216571,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFSc5UFi0IKpOA3kl5Kb2PR5ZfOAmDvkks5qlwnagaJpZM4Jy7Il
.
For some specific calls like e.g. finAllTopCategory etsy allows an extra "language" parameter to be sent. This change enables this extra parameter.
Allow language parameter
add getLastResponseHeaders to access Etsy X-Ratelimit-Limit and X-Ratelimit-Remaining
add access to response headers in EtsyClient.php
https://www.etsy.com/developers/documentation/reference/listing#method_createlisting
2010_2015 is not valid anymore because throws an exception in the server side
The validations for booleans as strings was because i had a exception on updateListingVariation on param is_available, the true value works well but false doesn't
https://www.etsy.com/developers/documentation/getting_started/api_basics#type_boolean
TODO update the test for booleans