position search-bar properly according to window #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamonuwa
reviewed
Nov 5, 2018
| @@ -2,7 +2,7 @@ | |||
| <form class="search-bar" | |||
| @submit.prevent="search()"> | |||
| <input type="text" | |||
| placeholder="What are you looking for?" | |||
| placeholder="Search" | |||
There was a problem hiding this comment.
Can we increase the size of the search bar? Every other thing looks good to me
There was a problem hiding this comment.
It needs to fit on mobile and this "What are you looking for?" is too big.
There was a problem hiding this comment.
Can we make it overlay on click? So that we can have autocomplete for the search
There was a problem hiding this comment.
Will fit in on mobile and desktop better
There was a problem hiding this comment.
i dont' think we should overlay the menu because then you can't click the "next" button for categories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #124