Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #1492

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

angel-christian25
Copy link

No description provided.

@elucash
Copy link
Member

elucash commented Feb 9, 2024

sorry for the long delays. Because the changes are big it's reasonably hard to say if those are ok. I hoped someone else can look at it, so I don't have to learn this part of the codebase and remember many things from some years ago.
If there's still intention to land this, I can have another deeper look, given the following.

  1. Formatting in many files are disregarded (some other style is introduced in some files, indentation etc, please match to the rest of the code)
  2. Don't extract(move to top level) classes in Naming, no need to do so. Try to provide just minimal factory method if you need some of those and even consider avoiding it, is there really no other way?
  3. It is unclear why move internals of hasValueOrVirtualFields to encoding? the new method is not used in this PR.
  4. Which tests to rely on to verify that refactoring doesn't change the behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants