A couple testing tweaks #928
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it might seem like panicking here would speed up debugging, because it would provide a backtrace directly to something approximating the root cause of the translation failure.
sadly, this is not at all the case: `translate_failure` is only called from the top-level `translator::translate` function, which decides whether to call it based on whether the more interesting functions such as `convert_decl` and `convert_main` return `Err(_)`. by the time `translate_failure` runs, the interesting functions have returned and the only relevant info is in the error string that we print *before* panicking. as such, the backtraces always look like this:
thread 'main' panicked at 'Translation failed, see error above', c2rust-transpile/src/translator/mod.rs:486:9
stack backtrace:
0: rust_begin_unwind
at /rustc/d394408fb38c4de61f765a3ed5189d2731a1da91/library/std/src/panicking.rs:584:5
1: core::panicking::panic_fmt
at /rustc/d394408fb38c4de61f765a3ed5189d2731a1da91/library/core/src/panicking.rs:142:14
2: c2rust_transpile::translator::translate
3: c2rust_transpile::transpile_single
4: <core::iter::adapters::map::Map<I,F> as core::iter::traits::iterator::Iterator>::fold
5: <alloc::vec::Vec<T> as alloc::vec::spec_from_iter::SpecFromIter<T,I>>::from_iter
6: c2rust_transpile::transpile
7: c2rust_transpile::main
this does not bring joy. we should just exit(1) here.
this makes tests fail at the translation step rather than when C compilation fails due to the failed translation step
|
What's the status of this? |
Someone with a mac needs to triage it. Volunteers welcome, or I can spend some time trying to get a VM to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR mostly just to run CI.