Align infos #598
Open
Align infos #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
force-pushed
the
kkysen/pfb/extra-info/print-format
branch
from
f67518c
to
cff03cc
Compare
kkysen
force-pushed
the
kkysen/pfb/extra-info/renames
branch
from
3b5d06c
to
f547ea3
Compare
…ting `""` for non-existent infos, not nothing at all.
kkysen
force-pushed
the
kkysen/pfb/extra-info/print-format
branch
from
cff03cc
to
3e69048
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns each of the infos printed so that they're much easier to scan while reading. This is done by adding a
NodeInfo::fmt_with_sepjust likeNode::fmt_with_sep. And non-existent infos are now printed as an empty""string instead of just nothing at all, allowing the alignment to work properly.