fix(server): new full sync return stacked assets individually #9189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldietzler
approved these changes
Apr 30, 2024
Deploying immich with
|
| Latest commit: |
8dfebb4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://16d35088.immich.pages.dev |
| Branch Preview URL: | https://fix-new-full-sync-return-sta.immich.pages.dev |
jrasm91
approved these changes
Apr 30, 2024
| @@ -710,11 +710,11 @@ export class AssetRepository implements IAssetRepository { | |||
| ], | |||
| }) | |||
| getAllForUserFullSync(options: AssetFullSyncOptions): Promise<AssetEntity[]> { | |||
| const { ownerId, isArchived, withStacked, lastCreationDate, lastId, updatedUntil, limit } = options; | |||
There was a problem hiding this comment.
Can you remove with stacked from the options interface then?
|
Fynn, I think we need to fix the tests as well, correct? |
Yes, I'll fix them. But it would be good to know beforehand if the sync method now works for your "test" instance ;-) |
jrasm91
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the issue that stacked child assets are not returned in large list (only as children of the parent).
Also returns archived partner assets to be backwards compatible to the getAllAssets endpoint.
Needed for #8842
mobile app expects all assets to be returned regardless of their stacked status