Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed delete on imba.locals #873

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/imba/src/imba/storage.imba
Expand Up @@ -76,9 +76,14 @@ class Storage
return item

def deleteProperty target, name
let key = ns + name
delete cache[key]
return store.removeItem(key)
let key = String(ns) + ':' + name

delete cache.raw[key]
delete cache.rich[key]

store.removeItem(key)

return yes

export const locals = new Proxy(fn,new Storage(global.localStorage))

Expand Down