Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix padding and margin for LineLabels and Tooltips #824 #1587

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

k0psutin
Copy link
Contributor

I wanted to make a PR to check with you @imaNNeo that, this PR is going on the right direction. I still need to make more testing, so a draftish PR.

This PR is for #824 and there were also discussion about adding padding/margin for the tooltips as well.

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

Attention: Patch coverage is 93.82716% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 87.41%. Comparing base (930ac12) to head (437af1f).
Report is 14 commits behind head on main.

❗ Current head 437af1f differs from pull request most recent head 3ba03f4. Consider uploading reports for the commit 3ba03f4 to get more accurate results

Files Patch % Lines
lib/src/chart/line_chart/line_chart_painter.dart 64.28% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1587      +/-   ##
==========================================
- Coverage   87.52%   87.41%   -0.11%     
==========================================
  Files          45       46       +1     
  Lines        3078     3092      +14     
==========================================
+ Hits         2694     2703       +9     
- Misses        384      389       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib/src/chart/base/axis_chart/axis_chart_data.dart Outdated Show resolved Hide resolved
lib/src/chart/base/axis_chart/axis_chart_data.dart Outdated Show resolved Hide resolved
lib/src/chart/base/axis_chart/axis_chart_painter.dart Outdated Show resolved Hide resolved
lib/src/chart/bar_chart/bar_chart_data.dart Show resolved Hide resolved
lib/src/extensions/rect_extension.dart Outdated Show resolved Hide resolved
@k0psutin
Copy link
Contributor Author

k0psutin commented Mar 22, 2024

What about these changes? There are no more margin parameters, everything is done by vertical and horizontal offsets. I had to generate mockito files again, so I could write more tests, but I have no idea why it bumped the Mockito version on the comments.

// Mocks generated by Mockito 5.4.4 from annotations

@imaNNeo
Copy link
Owner

imaNNeo commented May 8, 2024

HI, can you please resolve the conflicts?
Then I can review it

@k0psutin k0psutin force-pushed the feature/padding-for-line-touch-tooltip-data branch from 437af1f to d1ade1b Compare May 12, 2024 17:01
@k0psutin
Copy link
Contributor Author

k0psutin commented May 12, 2024

There were many conflicts, but hopefully everything is okay now. :) Not sure about the changelog format though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants