Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix miss touched section in Pie Chart #1506

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

samir7osny
Copy link

solves #1505

This PR uses the Path.contains instead of complex calculations.

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (b3529d3) 86.67% compared to head (f7a387e) 86.54%.
Report is 26 commits behind head on master.

Files Patch % Lines
lib/src/chart/pie_chart/pie_chart_painter.dart 58.33% 5 Missing ⚠️
lib/src/extensions/bar_chart_data_extension.dart 81.25% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1506      +/-   ##
==========================================
- Coverage   86.67%   86.54%   -0.14%     
==========================================
  Files          45       45              
  Lines        3016     3024       +8     
==========================================
+ Hits         2614     2617       +3     
- Misses        402      407       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imaNNeo
Copy link
Owner

imaNNeo commented Nov 26, 2023

Please fix the test CI issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants