Use the default theme available by the themeData for tooltips instead… #1464
+70
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of library's custom theme imaNNeo#1377
imaNNeo
reviewed
Nov 5, 2023
| @@ -764,7 +762,6 @@ class BarTouchTooltipData with EquatableMixin { | |||
| /// Used for equality check, see [EquatableMixin]. | |||
| @override | |||
| List<Object?> get props => [ | |||
| tooltipBgColor, | |||
There was a problem hiding this comment.
You need to add tooltipThemeData instead
Codecov Report
@@ Coverage Diff @@
## master #1464 +/- ##
==========================================
- Coverage 86.54% 86.45% -0.10%
==========================================
Files 45 45
Lines 2996 3005 +9
==========================================
+ Hits 2593 2598 +5
- Misses 403 407 +4
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
imaNNeo
reviewed
Nov 5, 2023
| @@ -3,6 +3,7 @@ | |||
| * **BUGFIX** (by @imaNNeo) Fix Negative BarChartRodStackItem are not drawn correctly bug, #1347 | |||
| * **BUGFIX** (by @imaNNeo) Fix bar_chart_helper minY calculation bug, #1388 | |||
| * **IMPROVEMENT** (by @imaNNeo) Consider fraction digits when formatting chart side titles, #1267 | |||
| * **IMPROVEMENT** (by @devilk10) Use the default theme available by the themeData for tooltips instead of color params #1464 | |||
There was a problem hiding this comment.
You need to add this line in the new version tag, for example create a ## newVersion section and add your changelog there
(Please read the contributing guideline carefully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… of library's custom theme #1377