Gauge Chart #1424
Gauge Chart #1424
Conversation
|
To view this pull requests documentation preview, visit the following URL: docs.page/imanneo/fl_chart~1424 Documentation is deployed and generated using docs.page. |
Codecov Report
@@ Coverage Diff @@
## master #1424 +/- ##
==========================================
+ Coverage 86.48% 87.02% +0.54%
==========================================
Files 45 49 +4
Lines 2982 3245 +263
==========================================
+ Hits 2579 2824 +245
- Misses 403 421 +18
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
FlorianArnould
force-pushed
the
feature/gauge-chart-v2
branch
from
61c300f
to
c4d5647
Compare
| final bool showChangingColorTicks; | ||
|
|
||
| static GaugeTicks? lerp(GaugeTicks? a, GaugeTicks? b, double t) { | ||
| // TODO(FlorianArnould): if showChangingColorTicks are different |
There was a problem hiding this comment.
Yes if we want a smooth transition on the color ticks
But would be deleted if we go for another approach like discussed here
#1424 (comment)
| double gaugeRadius(Size size) => size.shortestSide / 2; | ||
| } | ||
|
|
||
| class GaugePosition { |
There was a problem hiding this comment.
Please make this class private (as we need this object only here)
| } | ||
| } | ||
|
|
||
| class Range { |
| } | ||
| } | ||
|
|
||
| class DegreeAngleRange { |
|
When I put tick count: 3, I see 4 thicks. Is it intentional? |
| List<Object?> get props => [color]; | ||
| } | ||
|
|
||
| class VariableGaugeColor |
There was a problem hiding this comment.
This is a confusing approach in this project. Because we didn't use this approach on the other charts.
I would prefer to have a callback to get the progress and return a color (what we do in other charts).
Or a list of colors if you want to handle the gradient.
By the way, I can add these kinds of improvements if you allow me
There was a problem hiding this comment.
The idea is to be able to display some colored ticks at the angle the color changes.
If you work with a callback, you cannot get this angle precisely and moreover your will need to call it a lot of times with values between 0 and 1 to scan when the color changes.
| height: 250, | ||
| child: GaugeChart( | ||
| GaugeChartData( | ||
| value: _value, |
There was a problem hiding this comment.
I think we can have a list of values (each value can have startAngle and endAngle).
Then we can draw them on top of each other.
This way, it is more customizable.
Look at these samples:
The 3 grey's are the ticks you asked and the colored one is the one showed because of the showChangingColorTicks on GaugeTicks, this defaults to true |
|
Can you update your branch, please? And reply to the other discussions? |
|
Any updates to adding the Gauge Chart? Thank you. |
|
@FlorianArnould & @imaNNeo Thank you for your work on this topic. How can I help to push the Gauge Chart to the library? |
The implementation of the gauge chart (discussed here #199)