Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RTL language causes overlapping in settings, #4888 #4889

Merged
merged 3 commits into from
May 25, 2024
Merged

Commits on Apr 25, 2024

  1. Fix RTL language causes overlapping in settings, #4888

    This commit will:
    - Correct the constraints in PrefSubViewController.xib
    - Change the Mirror setting to Never on the color wells in the XIB
    - Change the language-direction of the battery icon from Fixed to Left
      to Right, Mirrors
    
    This corrects a problem with color wells overlapping their labels on the
    Subtitle tab of IINA's settings. This also changes the battery icon
    shown in full screen mode to flip in a RTL language correcting another
    overlapping problem.
    low-batt committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    56f5d04 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Configuration menu
    Copy the full SHA
    29f6557 View commit details
    Browse the repository at this point in the history
  2. Fix RTL language causes overlapping in settings, #4888

    This commit will:
    - Correct the constraints in PrefSubViewController.xib
    - Change the Mirror setting to Never on the color wells in the XIB
    - Change the direction of the battery icon from Fixed to Both
    - Add a reversed image to the battery icon
    - Add a additionalInfoLabelXConstraint outlet to MainWindowController
    - Add code to MainWindowController.windowDidLoad to adjust
      additionalInfoLabelXConstraint to center the label that provides the
      charge state when the battery icon is reversed
    
    This corrects a problem with color wells overlapping their labels on the
    Subtitle tab of IINA's settings. This also changes the battery icon
    shown in full screen mode to flip in a RTL language correcting another
    overlapping problem.
    low-batt committed May 24, 2024
    Configuration menu
    Copy the full SHA
    cdbc622 View commit details
    Browse the repository at this point in the history