Fix RTL language causes overlapping in settings, #4888 #4889
Conversation
|
See issue #4776 for a screenshot of the RTL overlaps. IINA 1.3.4: With the changes in this PR… |
This commit will: - Correct the constraints in PrefSubViewController.xib - Change the Mirror setting to Never on the color wells in the XIB - Change the language-direction of the battery icon from Fixed to Left to Right, Mirrors This corrects a problem with color wells overlapping their labels on the Subtitle tab of IINA's settings. This also changes the battery icon shown in full screen mode to flip in a RTL language correcting another overlapping problem.
low-batt
force-pushed
the
he-sub-settings
branch
from
3dc0a26
to
56f5d04
Compare
|
The issue with the malformed color wells in RTL has been fixed: But the mirroring applied by AppKit to the battery icon results in a blurry image: @lhc70000 will be generating a reversed battery image. I will then add it to the existing battery icon image set as a I have set this to be a draft until the blurry battery problem is corrected. |
|
It seems to me that a perfect inversion is like this: |
I mirrored the PDF from here simply using Apple Preview, it seems to keep full quality. |
|
Thanks! But… been there, done that. It all looked good in Preview and in Xcode, but at runtime the flipped battery looks just like the original battery. It faces the wrong direction. This is because Apple Preview does not remake the PDF, it adds a rotate tag to it. Seems AppKit does not support the tag. At least I think that is what was happening. Did I miss something? |
|
Yes, it looks like you're right :( |
|
Took me a while to figure out what was happening. Since Xcode showed the reversed PDF correctly I was thinking the code was not picking the RTL version of the battery. @lhc70000 created the battery icon. He will be able to provide a flipped one that matches the existing one. |
|
Oh. I missed that detail. My thoughts are that IINA should not try to change this. This is the behavior Apple supplies for an AppKit NSColorWell. If this is incorrect then Apple needs to fix it. Just to be sure I ran the little test program I wrote while working on this and confirmed this is the Apple supplied RTL behavior for this component. |
This commit will:
PrefSubViewController.xibMirrorsetting toNeveron the color wells in the XIBFixedtoLeft to Right, MirrorsThis corrects a problem with color wells overlapping their labels on the Subtitle tab of IINA's settings. This also changes the battery icon shown in full screen mode to flip in a RTL language correcting another overlapping problem.
Description: