Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored home page and avenger detail #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactored home page and avenger detail #58

wants to merge 1 commit into from

Conversation

anohene1
Copy link

Refactored home page into new file and moved avenger_detail into new folder for best coding practices.

@M-A-D-A-R-A
Copy link
Contributor

Refactored home page into new file and moved avenger_detail into new folder for best coding practices.

Can You share an SS of what UI it is looking like ?

@anohene1
Copy link
Author

anohene1 commented Oct 13, 2021 via email

@M-A-D-A-R-A
Copy link
Contributor

M-A-D-A-R-A commented Oct 14, 2021

I didn't change the look of the UI at all. I saw the code on github and saw that the homepage is in the main.dart file, which is considered bad coding practices. So I refactored the homepage code into a new file under a new folder I called 'screens'. I moved the avenger_detail into the screens folder as well to keep everything consistent and organized. A very minor pull request that doesn't change how the app looks or behave in any way.

On Wed, Oct 13, 2021, 2:04 PM Nishant Andoriya @.***> wrote: Refactored home page into new file and moved avenger_detail into new folder for best coding practices. Can You share an SS of what UI it is looking like ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#58 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALRU2TYOTFCP5OZV7IZ6KG3UGWGYTANCNFSM5F25CKEQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

It cool, its just there are some migration issues, also can u try to not change the auto generated file in your IDE ? That will be more helpful for merging.

GitHub
GitHub is where people build software. More than 65 million people use GitHub to discover, fork, and contribute to over 200 million projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants