Add functions update_GO_names, cap_names #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add data.table, ontologyIndex, and utils to imports. Update Roxygen version.
`update_GO_names` pulls official GO term descriptions from the appropriate OBO file from the Gene Ontology Consortium. Uses `data.table` for fast replacement of values while merging, but can easily be rewritten with `dplyr` to remove that import. `cap_names` capitalizes the first letter of each term description unless there is special capitalization (e.g., "mRNA" would not be capitalized); improves visualizations.
|
Thank you for doing this. This is a really nice enhancement and I am glad you shared the code. I still feel like this is outside the scope of the package and adds some extra dependencies, so I am not ready to merge it, but it's definitely helpful to have it here in case anyone is looking for such functionality. |
|
@igordot No worries. I'll probably make a helper package, then, that has some helper functions for this and the |
|
A helper package is a great idea. I thought about suggesting that, but it seemed like an overkill for one function. Makes more sense as you add more functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update_GO_namespulls official GO term descriptions from the appropriate OBO file from the Gene Ontology Consortium. Usesdata.tablefor fast replacement of values while merging, but can easily be rewritten withdplyrto remove that import.cap_namescapitalizes the first letter of each term description unless there is special capitalization (e.g., "mRNA" would not be capitalized); improves visualizations.