Parsing of custom message attributes

[Judas]

More explanations here : https://community.igniterealtime.org/message/255265#255265

[MarcFRICOU]

👍

[Flowdalic]

I've replied at https://community.igniterealtime.org/message/255393#255393
Please keep the discussion there. Thank you.

[Flowdalic]

Why construct this every time the method is called? And why is it a List? This should be a static Set.

[Flowdalic]

I've just looked at this again, and I think that

    public static Map<String, String> getCustomAttributes(XmlPullParser parser) {
        Map<String, String> customAttributes = new LinkedHashMap<>();
        for (int i = 0; i < parser.getAttributeCount(); i++) {
            String attributeName = parser.getAttributeName(i);
            boolean isLangAttribute = "lang".equals(attributeName) && "xml".equals(parser.getAttributePrefix(i));
            if (!Stanza.REGISTERED_ATTRIBUTES.contains(attributeName) && !isLangAttribute) {
                String attributeValue = parser.getAttributeValue(i);
                customAttributes.put(attributeName, attributeValue);
            }
        }
        return customAttributes;
    }

should take the attribute prefix into account and eventually prefix it. This is untested, but I believe that if we have

<element xmlns='foo' xmlns:myns='https://my.org' attr1='x' myns:attr2='y'>

then the current code would produce a map of

attr1 → x
myns → https://my.org
attr2 → y

while it should produce a map like

attr1 → x
xmlns:myns → https://my.org
myns:attr2 → y

If that's the case, then this should be fixed and a unit test for this should be created.

[Flowdalic]

Are you still up to pursue this further? Let me know if not, if so I probably squash it myself and add the missing features.

[Judas]

Hi Flow,
I didn't took the time to push it but I've added the unit test, and it seems the "good" result is returned by using your example. I'll try to update/push this week.

[FGRibreau]

We definitely need this 👍!

[IgniteRealtime-Bot]

This pull request has been mentioned on Ignite Realtime Community Forums. There might be relevant details there:

https://discourse.igniterealtime.org/t/support-for-custom-top-level-stanza-attributes/81376/2

[IgniteRealtime-Bot]

This pull request has been mentioned on Ignite Realtime Community Forums. There might be relevant details there:

https://discourse.igniterealtime.org/t/unable-to-get-message-data/85920/3