Migrate from libsignal-protocol-java to libsignal #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves away from
libsignal-protocol-javawhich was archived in February of 2022 and instead makes use oflibsignalwhich provides java bindings.The migration would require a minimum Android API level bump, since the
libsignalcode now usesjava.util.Optional, which is Java 8 (and some Android API level higher than the current min).I have not done any interoperability- or integration testing yet.
It is also not yet clear, if the ecosystem (OMEMO next) will fork libsignal, or maintain a fork of libsignal-protocol-java instead, so consider this more a feasibility analysis for now :)