Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sinttest] Additional Pubsub integration tests #457

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Flowdalic
Copy link
Member

@Flowdalic Flowdalic commented Jan 25, 2021

For XEP-0060 § 7.1.2. Asserts that publishing an item with the same ID
overwrites the previous item with that ID.

For XEP-0060 § 8.4.1: Assert that the server send a notification to
subscribers when deleting a node that exists.

Test for XEP-0060 § 8.4.3.2: Asserts that the server returns an
'item-not-found' error response when deleting a node that does not
exist.

Tests for non-optional ('MUST') conditions in XEP-0060 § 6.2

Tests for non-optional ('MUST') conditions in XEP-0060 § 6.1.6

Tests for non-optional ('MUST') conditions in XEP-0060 § 6.1.4

Tests for non-optional ('MUST') error conditions upon
subscription (XEP-0060 § 6.1.3).

Co-authored-by: Paul Schaub vanitasvitae@fsfe.org
Co-authored-by: Florian Schmaus flo@geekplace.eu

Thank you for your contribution!

For XEP-0060 § 7.1.2. Asserts that publishing an item with the same ID
overwrites the previous item with that ID.

For XEP-0060 § 8.4.1: Assert that the server send a notification to
subscribers when deleting a node that exists.

Test for XEP-0060 § 8.4.3.2: Asserts that the server returns an
'item-not-found' error response when deleting a node that does not
exist.

Tests for non-optional ('MUST') conditions in XEP-0060 § 6.2

Tests for non-optional ('MUST') conditions in XEP-0060 § 6.1.6

Tests for non-optional ('MUST') conditions in XEP-0060 § 6.1.4

Tests for non-optional ('MUST') error conditions upon
subscription (XEP-0060 § 6.1.3).

Co-authored-by: Paul Schaub <vanitasvitae@fsfe.org>
Co-authored-by: Florian Schmaus <flo@geekplace.eu>
@Flowdalic
Copy link
Member Author

A first run on my end showed that some tests fail. I don't know the root cause (yet).

@Flowdalic Flowdalic changed the title Additional Pubsub integration tests WIP: Additional Pubsub integration tests Jan 25, 2021
@Fishbowler
Copy link
Member

👀

@Fishbowler
Copy link
Member

I've fixed them, but can't push direct to your branch.
Rebased and fixed here: https://github.com/Fishbowler/Smack/tree/pubsub-sinttests

@guusdk
Copy link
Member

guusdk commented Jan 17, 2023

The current state of PubSubIntegrationTest as it exists @Fishbowler's branch have now been added to a new repository, https://github.com/igniterealtime/smack-sint-server-extensions, which aims to include tests that are server-oriented.

If there is no desire to merge these changes into Smack's repository, then this PR can be closed.

guusdk added a commit to XMPP-Interop-Testing/smack-sint-server-extensions that referenced this pull request Jan 17, 2023
This updates Smack's PubSub integration tests with the server-oriented extensions that were provided in igniterealtime/Smack#457
@guusdk guusdk changed the title WIP: Additional Pubsub integration tests [sinttest] Additional Pubsub integration tests Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants