Navigation Bar Fixed #2278
Open
Navigation Bar Fixed #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianguyen
reviewed
Feb 12, 2024
| @@ -109,10 +110,29 @@ export const Header = ({ | |||
| </div> | |||
| ); | |||
|
|
|||
| const [isSticky, setSticky] = useState(false); | |||
There was a problem hiding this comment.
This is a duplicate for line 28, it should be removed.
julianguyen
requested changes
Feb 12, 2024
|
I pulled down your branch, and the sticky navigation bar is not working on my end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have added details to make the navigation bar fixed to the top of the page when the user scrolls. My contribution is in Header.scss and index.jsx within the Header folder.
More Details
I think it would be helpful to improve the user experience.
Corresponding Issue
Here is the link to the issue #2271.