Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn when attempting to run egg using an unsupported version of go #113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexflint
Copy link

Thank you for this wonderful package!

I wonder whether you are interested in this pull request that checks that the version of go being executed is 1.16. With the wrong version of go, it looks like this:

$ egg build
2023/07/22 11:32:28 eggos requires go 1.16 but found go version go1.20.5 linux/amd64

Perhaps the test in this PR is too severe. Does eggos support older version of go, such as 1.15?

@mewmew
Copy link
Contributor

mewmew commented Jul 22, 2023

Hi @alexflint!

You are right in that Eggos is currently tied to Go 1.16. Support for Go 1.17 and above requires support for the custom asm calling convention introduced in Go 1.17 (see #100).

Regarding the warning message. Would it enough to do this on the go.mod level?

module github.com/icexin/eggos

go 1.16

Cheers,
Robin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants