Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: turn off default-features for opendal #272

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: turn off default-features for opendal #272

wants to merge 1 commit into from
+2 −1

Conversation

xxchan
Copy link

@xxchan xxchan commented Mar 4, 2024

This forces downstream applications to use opendal default features unnecessarily.

@xxchan
build: turn off default-features for opendal
70b7f58 
This forces downstream applications to use opendal default features unnecessarily.
@xxchan
Copy link
Author

xxchan commented Mar 4, 2024

@Xuanwo PTAL, thanks!

Xuanwo
Xuanwo approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed, but others looks fine to me.

@liurenjie1024
Copy link
Contributor

I'm checking the ci.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xxchan @liurenjie1024 @Xuanwo