Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue on_scroll to be run on operation #2438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Koranir
Copy link
Contributor

@Koranir Koranir commented May 11, 2024

Fixes #2437

Due to some inherent limitations, the operation can't access the on_scroll function, and so it sets a flag to be consumed on a later event. A better solution might be to give operations access to a Shell, so a message could be triggered manually, but that might not be necessary in this case.

@lufte
Copy link
Contributor

lufte commented May 11, 2024

@Koranir I'm gonna thank you on my behalf because this is good enough for me. Really clever.

I've applied to my fork :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

on_scroll is not fired when scrolling via operations
2 participants